Skip to content

mars2grib: Support ocean fields#181

Merged
dsarmany merged 6 commits intodevelopfrom
feature/mars2grib-ocean
Mar 18, 2026
Merged

mars2grib: Support ocean fields#181
dsarmany merged 6 commits intodevelopfrom
feature/mars2grib-ocean

Conversation

@tweska
Copy link
Copy Markdown
Member

@tweska tweska commented Mar 12, 2026

This PR adds support for ORCA grids in the representation concept and adds level mappings required to encode ocean fields.

This PR is meant to be used with these changes in MultIO: ecmwf/multio#247

@tweska tweska changed the title mars2grib: support ocean fields mars2grib: Support ocean fields Mar 12, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 1.85185% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.33%. Comparing base (87efe4a) to head (2223a27).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...it/mars2grib/backend/concepts/level/levelMatcher.h 0.00% 29 Missing ⚠️
...d/concepts/representation/representationEncoding.h 6.66% 14 Missing ⚠️
...etkit/mars2grib/backend/concepts/level/levelEnum.h 0.00% 9 Missing ⚠️
...nd/concepts/representation/representationMatcher.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
- Coverage    62.61%   62.33%   -0.28%     
===========================================
  Files          303      303              
  Lines        11554    11601      +47     
  Branches      1028     1036       +8     
===========================================
- Hits          7234     7232       -2     
- Misses        4320     4369      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsarmany dsarmany force-pushed the feature/mars2grib-ocean branch from d4d7d69 to f7e0b9b Compare March 15, 2026 11:27
Comment thread src/metkit/mars2grib/backend/concepts/level/levelEnum.h
@dsarmany dsarmany force-pushed the feature/mars2grib-ocean branch from 0da084e to 15c219c Compare March 18, 2026 08:34
Copy link
Copy Markdown
Contributor

@dsarmany dsarmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@dsarmany dsarmany force-pushed the feature/mars2grib-ocean branch from 15c219c to 2223a27 Compare March 18, 2026 09:33
@dsarmany dsarmany merged commit 15e8ed6 into develop Mar 18, 2026
5 checks passed
@dsarmany dsarmany deleted the feature/mars2grib-ocean branch March 18, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants